Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Missing identifier Field in LayoutDto for Novu Python SDK #5778

Closed
2 tasks done
Alleny244 opened this issue Jun 19, 2024 · 1 comment
Closed
2 tasks done
Labels

Comments

@Alleny244
Copy link

📜 Description

I'm encountering an issue with the Novu Python SDK while trying to create a layout. The API returns a 400 Bad Request error with the message indicating that the identifier should not be null or undefined and must be a string. However, the LayoutDto class in the SDK does not provide an option to pass the identifier, which seems to be required by the API.

Error Message

requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://api.novu.co/v1/layouts {'message': ['identifier should not be null or undefined', 'identifier must be a string'], 'error': 'Bad Request', 'statusCode': 400}

👟 Reproduction steps

  1. Create a LayoutDto instance without an identifier field.
  2. Attempt to create a layout using the Novu Python SDK.
  3. Observe the 400 Bad Request error.

👍 Expected behavior

The layout should be created successfully without a 400 Bad Request error.

👎 Actual Behavior with Screenshots

The API returns a 400 Bad Request error indicating that the identifier field is missing.
Screenshot 2024-06-19 at 4 57 00 PM

Novu version

Novu SaaS

npm version

NA

node version

NA

📃 Provide any additional context for the Bug.

Add an identifier field to the LayoutDto class in the Novu Python SDK, allowing users to pass this value when creating a layout.

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

Yes I am willing to submit a PR!

Copy link

linear bot commented Jun 19, 2024

@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant