Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error classification logic for Tact's typed errors (Post-1.6) #319

Open
jubnzv opened this issue Mar 4, 2025 · 0 comments
Open

Update error classification logic for Tact's typed errors (Post-1.6) #319

jubnzv opened this issue Mar 4, 2025 · 0 comments
Labels
enhancement New feature or request
Milestone
v0.8

Comments

@jubnzv
Copy link
Member

jubnzv commented Mar 4, 2025

Currently, we inspect the Tact error stack to classify errors using heuristics:

misti/src/internals/exceptions.ts

Line 29 in ea4fa44

if (this.isParserError(tactStack)) {

However, the recent introduction of typed errors in Tact has broken this logic.
@jubnzv jubnzv added the enhancement New feature or request label Mar 4, 2025
jubnzv added a commit that referenced this issue Mar 4, 2025
@jubnzv
feat(exceptions): Improve Tact errors handling heurstic
c52fd94 
Hacks #319 for common cases
Esorat pushed a commit to Esorat/misti that referenced this issue Mar 4, 2025
@jubnzv @Esorat
feat(exceptions): Improve Tact errors handling heurstic
6d415fa 
Hacks nowarp#319 for common cases
@jubnzv jubnzv added this to the v0.8 milestone Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.8
Development

No branches or pull requests
1 participant
@jubnzv