Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing metrics for transformer for mvtx #2383

Open
vigith opened this issue Feb 6, 2025 · 4 comments · May be fixed by #2389
Open

missing metrics for transformer for mvtx #2383

vigith opened this issue Feb 6, 2025 · 4 comments · May be fixed by #2389
Assignees
@adarsh0728
Labels
area/monovertex Mono Vertex bug Something isn't working rust Rust
Milestone
1.5

Comments

@vigith
Copy link
Member

vigith commented Feb 6, 2025

Dropped message metrics counter is missing for Transformer for MonoVertex
@vigith vigith added area/monovertex Mono Vertex bug Something isn't working rust Rust labels Feb 6, 2025
@vigith vigith added this to the 1.5 milestone Feb 6, 2025
@adarsh0728
Copy link
Contributor

can i pick this up?

@vigith
Copy link
Member Author

vigith commented Feb 9, 2025

can i pick this up?

absolutely :)

@KeranYang
Copy link
Member

@adarsh0728 please also consider adding other useful metrics for transfomer. Here is what we have for pipeline: https://github.com/numaproj/numaflow/blob/main/pkg/metrics/metrics.go#L224

@adarsh0728 adarsh0728 linked a pull request Feb 10, 2025 that will close this issue
Draft
@vigith vigith changed the title Dropped metrics is missing for transformer for mvtx missing metrics for transformer for mvtx Feb 10, 2025
@vigith
Copy link
Member Author

vigith commented Feb 10, 2025

i have changed the title to include all missing metrics.

@yhl25 i think some metrics are missing in pipeline too, e.g., dropped. If yes, let's create a new issue and track metrics missing for pipeline too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adarsh0728 adarsh0728

Labels
area/monovertex Mono Vertex bug Something isn't working rust Rust
Projects
None yet
Milestone
1.5
Development

Successfully merging a pull request may close this issue.

fix: add missing metrics for transformer for mvtx adarsh0728/numaflow
3 participants
@vigith @KeranYang @adarsh0728