Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeltaEncoder should encode the delta not the input #545

Open
roiebe opened this issue Oct 17, 2018 · 0 comments
Open

DeltaEncoder should encode the delta not the input #545

roiebe opened this issue Oct 17, 2018 · 0 comments

Comments

@roiebe
Copy link

roiebe commented Oct 17, 2018

org.numenta.nupic.encoders.DeltaEncoder.java line 113:

super.encodeIntoArray(input, output);

should be:

super.encodeIntoArray(delta, output);

see python version: nupic/encoders/delta.py line 79:

self._adaptiveScalarEnc.encodeIntoArray(delta, output, learn)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant