-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TA Mode doesn't work for some courses #3929
Comments
This happens because TA mode filters out all lecture lessons, so the issue arises because both CS2103T and CS3281 only have lecture lessons. One way to fix this would be to make lectures also togglable. @zwliew, I don't mind working on this. |
Yes, let's make all lessons types TA-able. |
I've run into a bit of a problem for CS2103T specifically. Because one class number is associated with multiple lesson slots, this means that adding multiple tutorial slots will add a bunch of the lecture slots as well. For example, for a timetable with the following TA config:
This is because our toggle is based only on class numbers at the moment, so one way to overcome this is to store start and end times in |
I believe that adding just the start time (and day) would be enough to ensure that each slot is unique. If that works, please also add a migration to convert the current |
Describe the bug
Some courses cannot be set to "TA Mode".
Example courses:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
TA mode is enabled
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: