Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misconfigured GrumPHP #14

Open
Sweetchuck opened this issue Jan 5, 2022 · 0 comments
Open

Misconfigured GrumPHP #14

Sweetchuck opened this issue Jan 5, 2022 · 0 comments

Comments

@Sweetchuck
Copy link

robo-config 2.x bcb737c

PHPCS with GrumPHP

$ ./vendor/bin/grumphp run

GrumPHP is sniffing your code!
Running task 1/1: Phpcs... ✔

plain PHPCS

$ ./vendor/bin/phpcs --standard='vendor/drupal/coder/coder_sniffer/Drupal/' ./src/ ./tests/TaskTest.php

FILE: ./nuvoleweb/robo-config-2.x/src/Php/AppendConfiguration.php
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
 9 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
----------------------------------------------------------------------------------------------------------------


FILE: ./nuvoleweb/robo-config-2.x/src/Php/BaseConfiguration.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 13 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------


FILE: ./nuvoleweb/robo-config-2.x/src/Php/BaseConfigurationInterface.php
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
 9 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
----------------------------------------------------------------------------------------------------------------


FILE: ./nuvoleweb/robo-config-2.x/src/Php/PrependConfiguration.php
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
 9 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
----------------------------------------------------------------------------------------------------------------


FILE: ./nuvoleweb/robo-config-2.x/src/Php/WriteConfiguration.php
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
 9 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
----------------------------------------------------------------------------------------------------------------


FILE: ./nuvoleweb/robo-config-2.x/src/Php/loadTasks.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 12 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------


FILE: ./nuvoleweb/robo-config-2.x/src/Robo/loadTasks.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 17 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------


FILE: ./nuvoleweb/robo-config-2.x/src/loadTasks.php
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
 9 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
----------------------------------------------------------------------------------------------------------------


FILE: ./nuvoleweb/robo-config-2.x/tests/TaskTest.php
----------------------------------------------------------------------------------------------------------------------
FOUND 17 ERRORS AND 1 WARNING AFFECTING 17 LINES
----------------------------------------------------------------------------------------------------------------------
  25 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
  35 | ERROR   | [x] Visibility must be declared on method "setup"
  36 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  67 | ERROR   | [x] Return comment indentation must be 3 spaces, found 4 spaces
  70 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
  70 | ERROR   | [x] Calling class constructors must always include parentheses
 147 | ERROR   | [x] Return comment indentation must be 3 spaces, found 4 spaces
 160 | ERROR   | [x] Return comment indentation must be 3 spaces, found 4 spaces
 173 | ERROR   | [x] Return comment indentation must be 3 spaces, found 4 spaces
 185 | ERROR   | [x] Parameter comment indentation must be 3 spaces, found 4 spaces
 188 | ERROR   | [x] Return comment indentation must be 3 spaces, found 4 spaces
 202 | ERROR   | [x] Parameter comment indentation must be 3 spaces, found 4 spaces
 205 | ERROR   | [x] Return comment indentation must be 3 spaces, found 4 spaces
 212 | ERROR   | [x] Doc comment short description must end with a full stop
 215 | ERROR   | [x] Parameter comment indentation must be 3 spaces, found 4 spaces
 217 | ERROR   | [x] Parameter comment indentation must be 3 spaces, found 4 spaces
 225 | ERROR   | [x] Expected 1 blank line after function; 0 found
 226 | ERROR   | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 17 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------


@Sweetchuck Sweetchuck changed the title Miss configured GrumPHP Misconfigured GrumPHP Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant