Skip to content
This repository has been archived by the owner on Jul 9, 2023. It is now read-only.

SwitchCraft 3 ROM support #2

Open
3 of 4 tasks
tomodachi94 opened this issue Jan 9, 2023 · 10 comments
Open
3 of 4 tasks

SwitchCraft 3 ROM support #2

tomodachi94 opened this issue Jan 9, 2023 · 10 comments
Labels
enhancement New feature or request

Comments

@tomodachi94
Copy link
Member

tomodachi94 commented Jan 9, 2023

  • chatbox
  • Internal switchcraft API
  • bigfont
  • sc-peripherals.3d_printer
@tomodachi94 tomodachi94 added the enhancement New feature or request label Jan 9, 2023
@tomodachi94
Copy link
Member Author

SC3 ROM is available at https://github.com/SwitchCraftCC/sc3-rom.

@bananasov
Copy link

bananasov commented Jan 9, 2023

what about the 3d_printer peripheral and its methods and events?

The title is kinda misleading aswell, it's for the sc-peripherals part of SC, not the ROM. Only some parts such as chatbox is in the ROM

@tomodachi94
Copy link
Member Author

it's for the sc-peripherals part of SC, not the ROM.

Ah, I didn't realize there was an sc-peripherals mod. I'll get to that too.

Also, this is for the full ROM... did I miss any ROM APIs or modules in the list above?

@bananasov
Copy link

it's for the sc-peripherals part of SC, not the ROM.

Ah, I didn't realize there was an sc-peripherals mod. I'll get to that too.

Also, this is for the full ROM... did I miss any ROM APIs or modules in the list above?

I dont think ya did, but what about Plethora?

@tomodachi94
Copy link
Member Author

it's for the sc-peripherals part of SC, not the ROM.

Ah, I didn't realize there was an sc-peripherals mod. I'll get to that too.
Also, this is for the full ROM... did I miss any ROM APIs or modules in the list above?

I dont think ya did, but what about Plethora?

I'll start work on that in another issue.

I think I'm going to drop the branches model and just have users specify which ROMs they want in .luarc.json. It isn't as streamlined, but it's easier to maintain in the long-term.

@bananasov
Copy link

it's for the sc-peripherals part of SC, not the ROM.

Ah, I didn't realize there was an sc-peripherals mod. I'll get to that too.
Also, this is for the full ROM... did I miss any ROM APIs or modules in the list above?

I dont think ya did, but what about Plethora?

I'll start work on that in another issue.

I think I'm going to drop the branches model and just have users specify which ROMs they want in .luarc.json. It isn't as streamlined, but it's easier to maintain in the long-term.

How would that work?

@tomodachi94
Copy link
Member Author

tomodachi94 commented Jan 9, 2023

How would that work?

Currently, this line in .luarc.json is the main thing driving the autocomplete:

"library": [
    "./.lua-ls-definitions/meta/3rd/cc-tweaked/library"
]

If you wanted to, for example, use SC3's ROM and peripherals mod, you would change it to this:

"library": [
    "./.lua-ls-definitions/meta/3rd/cc-tweaked/library", 
+    "./.lua-ls-definitions/meta/3rd/switchcraft/library"
]

@bananasov
Copy link

Ah okay I see.

How would that work?

Currently, this line in .luarc.json is the main thing driving the autocomplete:

"library": ["./.lua-ls-definitions/meta/3rd/cc-tweaked/library"]

If you wanted to, for example, use SC3's ROM and peripherals mod, you would change it to this:

"library": ["./.lua-ls-definitions/meta/3rd/cc-tweaked/library", "./.lua-ls-definitions/meta/3rd/switchcraft/library"]

@tomodachi94
Copy link
Member Author

tomodachi94 commented Jan 10, 2023

I'm probably going to outsource these extra compatibility modules to separate repositories and provide instructions for adding them as submodules.

@bananasov
Copy link

I'm probably going to outsource these extra compatibility modules to separate repositories and provide instructions for adding them as submodules.

Seems like a reasonable thing to do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants