Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have any plan to set minimal requirements to 0.10.x? #3277

Open
delphinus opened this issue Sep 3, 2024 · 3 comments
Open

Have any plan to set minimal requirements to 0.10.x? #3277

delphinus opened this issue Sep 3, 2024 · 3 comments
Labels
enhancement Enhancement to performance, inner workings or existent features

Comments

@delphinus
Copy link
Member

Is your feature request related to a problem? Please describe.
Now telescope.nvim needs Neovim 0.9.x and it is written in README. Should we think about changing this to 0.10.x?

With using 0.10.x, we can use new features, such as vim.iter, vim.system, ……, and can remove polyfills for avoiding deprecation messages (for vim.tbl_flatten and so on).

Describe the solution you'd like
Update README to write this plugin needs 0.10.x.

Describe alternatives you've considered

Additional context
telescope-frecency.nvim follows telescope.nvim for minimum requirements. If telescope.nvim makes minimum to 0.10.x, it is happy that we can use vim.iter in telescope-frecency.nvim.

ref nvim-telescope/telescope-frecency.nvim#259

@delphinus delphinus added the enhancement Enhancement to performance, inner workings or existent features label Sep 3, 2024
@Conni2461
Copy link
Member

I have a wip branch for 0.10.x, probably do it this week. After that we also most likely release 0.2

@delphinus
Copy link
Member Author

It's nice! OK, I will set min: 0.10.x to telescope-frecency.nvim after releasing telescope.nvim 0.2. 👍🏻

@clason
Copy link
Contributor

clason commented Sep 7, 2024

And I strongly encourage followup PRs to move to Neovim API as much as possible (vim.fs, vim.system, etc.; there's also a minimal async module used in several plugins that we're hoping to get into core one of these days as well as a minimal log module).

Also, nvim_strwidth is a thing and should be fast-safe, as is charwidth() (or, better yet, vim.utf_str*). So no reason for FFI tomfoolery with strings!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to performance, inner workings or existent features
Projects
None yet
Development

No branches or pull requests

3 participants