Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate data classes to Pydantic-based models #19

Open
nwunderly opened this issue Sep 26, 2022 · 0 comments
Open

Migrate data classes to Pydantic-based models #19

nwunderly opened this issue Sep 26, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest

Comments

@nwunderly
Copy link
Owner

We want to make our data classes in models.py compatible with Pydantic in order to facilitate better interoperability with API and database use cases.

What would need to be done:

  • Add pydantic as a dependency
  • Make DiscordObject a subclass of pydantic's BaseModel class
  • Implement pydantic-compatible type hints in all data classes
  • Ensure that all data classes in that file are compliant with pydantic's type checking
  • No breaking changes to the actual library should be necessary for this

Happy Hacktoberfest! 😄

@nwunderly nwunderly added enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest labels Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest
Projects
None yet
Development

No branches or pull requests

1 participant