Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible parameters visible during rule creation #103

Open
myshoeshurt opened this issue Dec 20, 2018 · 2 comments
Open

Incompatible parameters visible during rule creation #103

myshoeshurt opened this issue Dec 20, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@myshoeshurt
Copy link
Contributor

I was making a rule, and when I reached the "execute those actions" part this is the flow I got:

  • Execute an action on an entire kind of things
    • Lights
      • Turn Lights on or off ->

And inside I had 2 parameters, one of which makes the rule incompatible.

  • Use static value as parameter
  • Use event parameter

EventParameter is incompatible with this, but given as an option. Also the error message that you get is really vague and does not help much.

Suggestion to fix - either remove as an option when it's not compatible with the type of rule, or add better error messages. The nymead log correctly reports this rule as incompatible and adds this useful line:
Rule not consistent. The exitActions will never be executed if the rule contains an eventDescriptor but no stateEvaluator.

@myshoeshurt myshoeshurt added the bug Something isn't working label Dec 20, 2018
@mzanetti
Copy link
Member

I'd need to know what the event descriptor was you had in that rule

@myshoeshurt
Copy link
Contributor Author

The event descriptor gave me an option that caused the issue.
To be precise, it allowed me to "Turn Lights on or off" and instead of passing a static value as parameter, it allowed me to use event parameter - City Name - humidity changed - humidity .
The rule is based on tracking humidity, so I guess that's why it was allowed. My suggestion would be to disable anything but static values to devices that are Lights category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants