From e95a901812b950dea361a48f9c90b5d3f08a8115 Mon Sep 17 00:00:00 2001 From: Danny Willems Date: Fri, 4 Oct 2024 13:57:34 +0200 Subject: [PATCH] Clippy: introducing clippy.toml And add support up to 8 arguments. --- clippy.toml | 6 ++++++ poly-commitment/src/ipa.rs | 1 - poly-commitment/src/lib.rs | 1 - 3 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 clippy.toml diff --git a/clippy.toml b/clippy.toml new file mode 100644 index 0000000000..66b530223b --- /dev/null +++ b/clippy.toml @@ -0,0 +1,6 @@ +# Default is 7. However, it seems to be arbitrary. Some protocols do require +# many parameters, like polynomial commitment scheme when we want to make an +# opening. +# Note that we should not use too much this threshold, and stay clean in the +# choice of our routine parameters. +too-many-arguments-threshold = 8 \ No newline at end of file diff --git a/poly-commitment/src/ipa.rs b/poly-commitment/src/ipa.rs index 7608850980..5b5e4f7a5c 100644 --- a/poly-commitment/src/ipa.rs +++ b/poly-commitment/src/ipa.rs @@ -835,7 +835,6 @@ impl SRS { /// - rng: used for blinders for the zk property /// A slight modification to the original protocol is done /// when absorbing the first prover message. - #[allow(clippy::too_many_arguments)] #[allow(clippy::type_complexity)] #[allow(clippy::many_single_char_names)] pub fn open>( diff --git a/poly-commitment/src/lib.rs b/poly-commitment/src/lib.rs index 73f3120bf1..92e9a3d58d 100644 --- a/poly-commitment/src/lib.rs +++ b/poly-commitment/src/lib.rs @@ -172,7 +172,6 @@ pub trait OpenProof: Sized + Clone { /// - `sponge`: Sponge used to coin and absorb values and simulate /// non-interactivity using the Fiat-Shamir transformation. /// - `rng`: a pseudo random number generator in case blinding is needed - #[allow(clippy::too_many_arguments)] fn open::ScalarField>>( srs: &Self::SRS, group_map: &::Map,