Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/ts-web: bump @noble/hashes from 1.4.0 to 1.5.0 in /client-sdk/ts-web #2018

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 4, 2024

Bumps @noble/hashes from 1.4.0 to 1.5.0.

Release notes

Sourced from @​noble/hashes's releases.

1.5.0

  • Scrypt: relax params check to allow r: 1, p: 8
  • Export additional typescript types
  • Add support for node.js v14.21.3 in addition to v16+
  • Export sha224, sha384, sha512_224, sha512_256 in single-file build

New Contributors

Full Changelog: paulmillr/noble-hashes@1.4.0...1.5.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from kostko as a code owner October 4, 2024 01:56
@dependabot dependabot bot added the c:client-sdk/typescript Category: TypeScript client SDK label Oct 4, 2024
@dependabot dependabot bot requested a review from pro-wh as a code owner October 4, 2024 01:56
@dependabot dependabot bot added the c:deps Category: external dependencies label Oct 4, 2024
@dependabot dependabot bot requested review from ptrus and peternose as code owners October 4, 2024 01:56
Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for oasisprotocol-oasis-sdk canceled.

Name Link
🔨 Latest commit 6a970f2
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-sdk/deploys/6700708b4874c900083bc2cc

Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release notes sound fine

Add support for node.js v14.21.3 in addition to v16+

that turned out to be paulmillr/noble-hashes#98, but what was a hashing library doing with random bytes? my search in their repo found nothing, only that it's exported from their utils module and used in a 'test/example.js'. and we don't want the lesson from xz to be lost on us, so let's also note that that file https://www.npmjs.com/package/@noble/hashes/v/1.5.0?activeTab=code doesn't appear in the distributed package

let's merge later

Bumps [@noble/hashes](https://github.com/paulmillr/noble-hashes) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/paulmillr/noble-hashes/releases)
- [Commits](paulmillr/noble-hashes@1.4.0...1.5.0)

---
updated-dependencies:
- dependency-name: "@noble/hashes"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/client-sdk/ts-web/noble/hashes-1.5.0 branch from cfaed71 to 6a970f2 Compare October 4, 2024 22:47
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.63%. Comparing base (fba7b2b) to head (6a970f2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2018   +/-   ##
=======================================
  Coverage   60.63%   60.63%           
=======================================
  Files         130      130           
  Lines        9604     9604           
=======================================
  Hits         5823     5823           
  Misses       3781     3781           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pro-wh
Copy link
Contributor

pro-wh commented Oct 5, 2024

@dependabot merge

@dependabot dependabot bot merged commit c883fcb into main Oct 5, 2024
28 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/client-sdk/ts-web/noble/hashes-1.5.0 branch October 5, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:client-sdk/typescript Category: TypeScript client SDK c:deps Category: external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant