-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OptCached doesn't take into account the date of the source #2713
Labels
Comments
@volodya-lombrozo can you please fix this? it's pretty urgent, since it blocks this: #2711 |
@yegor256 Yes, I'll |
@volodya-lombrozo it doesn't block #2711 anymore, but still would be nice to fix, since the entire caching mechanism is kind of broken now |
volodya-lombrozo
added a commit
to volodya-lombrozo/eo
that referenced
this issue
Dec 22, 2023
volodya-lombrozo
added a commit
to volodya-lombrozo/eo
that referenced
this issue
Dec 22, 2023
volodya-lombrozo
added a commit
to volodya-lombrozo/eo
that referenced
this issue
Dec 22, 2023
volodya-lombrozo
added a commit
to volodya-lombrozo/eo
that referenced
this issue
Dec 22, 2023
volodya-lombrozo
added a commit
to volodya-lombrozo/eo
that referenced
this issue
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment,
OptCached
accepts an XML document and returns its optimized version. It also checks, whether an already optimized XML exists in the cache. However, it doesn't pay attention to the date of the original XML and the date of the document in the cache. This often leads to errors because the data in the cache is already expired.I think, we should change the interface of
Optimization
fromFunction<XML, XML>
toFunction<Path, XML>
. It should accept the path of the source document, not the content of it.Also, I think it's better to use
Func
from Cactoos instead ofFunction
from JDK, since it allows checked exceptions to be thrown from theapply
method.The text was updated successfully, but these errors were encountered: