Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: ProfileListChanged doesn't trigger when a profile is deleted #1267

Open
BarryCarlyon opened this issue Nov 18, 2024 · 0 comments
Open

Comments

@BarryCarlyon
Copy link
Contributor

BarryCarlyon commented Nov 18, 2024

Operating System Info

Windows 11

Other OS

No response

OBS Studio Version

Other

OBS Studio Version (Other)

31.0.0-beta3

obs-websocket Version

Git

OBS Studio Log URL

Nothing in the log to suggest a relevant fault:

09:34:21.863: 	id: default
09:34:21.864: Switched to profile 'SomeTest' (SomeTest)
09:34:21.864: ------------------------------------------------
09:34:21.880: [mac-virtualcam] macOS Camera Extension activated successfully.
09:34:26.393: Number of remaining views: 1
09:34:26.394: ---------------------------------
09:34:26.394: video settings reset:
09:34:26.394: 	base resolution:   1920x1080
09:34:26.394: 	output resolution: 1280x720
09:34:26.394: 	downscale filter:  Bicubic
09:34:26.394: 	fps:               60/1
09:34:26.394: 	format:            NV12
09:34:26.394: 	YUV mode:          Rec. 709/Partial
09:34:26.394: NV12 texture support enabled
09:34:26.394: P010 texture support not available
09:34:26.396: Audio monitoring device:
09:34:26.396: 	name: Default
09:34:26.396: 	id: default
09:34:26.397: ------------------------------------------------
09:34:26.397: Removed profile 'SomeTest' (SomeTest)
09:34:26.397: ------------------------------------------------
09:34:26.397: Switched to profile 'BarryCarlyon Twitch' (BarryCarlyon_Twitch)
09:34:26.397: ------------------------------------------------
09:34:26.426: [mac-virtualcam] macOS Camera Extension activated successfully.

OBS Studio Crash Log URL

No response

Expected Behavior

When you delete a profile (either via websocket or UI) ProfileListChanged is triggered not just CurrentProfileChanged****

Current Behavior

Only CurrentProfileChanged no ProfileListChanged

Steps to Reproduce

  1. Have OBS with two profiles
  2. Connect a websocket client, listen for ProfileListChanged and CurrentProfileChanged
  3. Create a new profile, observe as ProfileListChanged as expected and a CurrentProfileChanged
  4. Delete the new profile, observe no ProfileListChanged you get only a CurrentProfileChanged

Anything else we should know?

Have not tested against "release" OBS

case OBS_FRONTEND_EVENT_PROFILE_LIST_CHANGED:

might suggest it's a "core obs issue" rather than a WebSocket one? But checking the OBS code I don't see anything obviously wrong

https://github.com/obsproject/obs-studio/blob/4652daf748e467415976682e41ea507d6fee8f25/UI/window-basic-main-profiles.cpp#L226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant