Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dune cache does not restore empty directories. #11117

Open
mefyl opened this issue Nov 12, 2024 · 1 comment
Open

Dune cache does not restore empty directories. #11117

mefyl opened this issue Nov 12, 2024 · 1 comment
Assignees

Comments

@mefyl
Copy link
Collaborator

mefyl commented Nov 12, 2024

Issue

Dune cache does not restore empty directories. On top of not being very nice, this has really bad consequences with caching because dune's rule digest algorithm does take empty directories in account, so restoring a rule from cache will invalidate all dependent rules as the sources hash will have changed.

This is especially painful with the dune pkg feature, as the Ocaml 5.2.0 tarball has an empty flexdll directory at the root, so pulling it from the cache will rebuild absolutely everything.

I suppose the correct behavior is to properly restore empty directories from cache. If not, they probably shouldn't count towards rule digests.

Reproduction

@ElectreAAS ElectreAAS self-assigned this Nov 12, 2024
@ejgallego
Copy link
Collaborator

Could this be related to #10931 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants