-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Improving the CLI #2097
Comments
Does that imply that |
That's a good point. I don't think it should, it should be the same as the current |
I checked selection of
Among these 451, default Makefile targets about 445 are various flavors of
These are rough numbers, since I discarded about 1/3 of repos (there was 2288 repos in |
@ksromanov Does |
I'm generally in favour of simpler consistency for the CLI, subcommands since higher level tools (e.g. VSCode rules, or Makefiles) invoke dune directly. For them, calling |
Unfortunately it does not :-(. But yes, you are right - I missed |
@ksromanov I feel like we are diverging from the original conversation. Please open a separate ticket to discuss improvements to |
If the motivation is to type less, wouldn't a shell completion mode be better? |
That's a fair point. In particular, I wonder how much we would still want the shorter command line if we add shell completion. Linking the ticket for shell completion: #126 |
I also think that shell completion would be far more effective and that adding any kind of cleverness is gratuitous. If we make a few straight forward improvements to polling mode, that would cut down on the dune invocations by 90% for me. And as Anil said, proper integration would make this even less relevant. |
After a lively discussion, it's time to make a decision. I regret to inform the enthusiasts of this issue that you will be required to input the 6 additional keystrokes to get dune to build something. My sincerest apologies. |
I propose to change the CLI as follow:
build
command is implicitly assumed if at least one ancestor directory contains adune
,dune-project
ordune-workspace
fileThe idea is to allow the user to type simply
dune
ordune @all
rather thandune build
ordune build @all
. The first rule prevents ambiguities and the condition on the second rule is to make sure thatdune
doesn't crawl the whole hard drive when called outside a project.The text was updated successfully, but these errors were encountered: