diff --git a/CHANGES.md b/CHANGES.md index cde92d2fa..2c6697a78 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -12,6 +12,7 @@ unreleased of the involved data-structures. (#1889) + test suite - Add a test case illustrating wrong open order proposed in issue #1900. (#1901) + - Add more short-paths tests cases (#1904) merlin 5.4.1 ============ diff --git a/tests/test-dirs/short-paths/issue1873.t b/tests/test-dirs/short-paths/issue1873.t new file mode 100644 index 000000000..4df0dc52b --- /dev/null +++ b/tests/test-dirs/short-paths/issue1873.t @@ -0,0 +1,45 @@ +We get a bad path for `hello` + + $ cat > foo.ml < module Foo = struct + > type t + > end + > + > module Bar = struct + > module Foo = struct + > type t = Foo.t + > end + > end + > + > open! Bar + > + > let hello : Foo.t = 0 + > EOF + +It happens regardless of whether short-paths is enabled + $ $MERLIN single type-enclosing -position 13:5 -filename foo.ml < foo.ml | jq .value[0].type -r + Bar.Foo.t + + $ echo "FLG -short-paths" > .merlin + $ $MERLIN single type-enclosing -position 13:5 -filename foo.ml < foo.ml | jq .value[0].type -r + Bar.Foo.t + +It seems to be related to shadowing somehow. This works: + $ cat > foo.ml < module Foo = struct + > type t + > end + > + > module Bar = struct + > module Baz = struct + > type t = Foo.t + > end + > end + > + > open! Bar + > + > let hello : Baz.t = 0 + > EOF + + $ $MERLIN single type-enclosing -position 13:5 -filename foo.ml < foo.ml | jq .value[0].type -r + Foo.t diff --git a/tests/test-dirs/short-paths.t/dep.mli b/tests/test-dirs/short-paths/short-paths.t/dep.mli similarity index 100% rename from tests/test-dirs/short-paths.t/dep.mli rename to tests/test-dirs/short-paths/short-paths.t/dep.mli diff --git a/tests/test-dirs/short-paths.t/run.t b/tests/test-dirs/short-paths/short-paths.t/run.t similarity index 100% rename from tests/test-dirs/short-paths.t/run.t rename to tests/test-dirs/short-paths/short-paths.t/run.t diff --git a/tests/test-dirs/short-paths.t/test.ml b/tests/test-dirs/short-paths/short-paths.t/test.ml similarity index 100% rename from tests/test-dirs/short-paths.t/test.ml rename to tests/test-dirs/short-paths/short-paths.t/test.ml