Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Following Errors about aggregate functions should be reported at the syntax analysis stage #273

Closed
ringfa11 opened this issue Sep 25, 2023 · 6 comments
Labels
bug Something isn't working question Further information is requested

Comments

@ringfa11
Copy link
Contributor

Question
In testcase result file test/case/result/primary-aggregation-func.result,
I found that some incorrect usages of aggregate functions are reported as Failure

image

However, I believe they should be reported as syntax errors. I tried MySQL version 8.0.34 on Windows, and it also gave syntax errors

1695650298980

@ringfa11 ringfa11 added the question Further information is requested label Sep 25, 2023
@hnwyllmm
Copy link
Collaborator

Good question!
I think you're right. The error message response by observer is not good enough.
Currently, miniob use plain string as the response and request message, so it is difficult to describe information clearly.
As a better option, miniob support mysql protocol now and we can fix such issues by mysql protocol. In the future, we can use mysql protocol as the basic protocol to do test.

@ringfa11
Copy link
Contributor Author

How can I switch to mysql protocal in miniob?
I have tried ./build/bin/observer -f ./etc/observer.ini -P mysql, but it seems not right.

@hnwyllmm
Copy link
Collaborator

What's wrong?

@hnwyllmm
Copy link
Collaborator

Which mysql client did you use?
mysql 8.0 is not tested yet.

@ringfa11
Copy link
Contributor Author

Which mysql client did you use? mysql 8.0 is not tested yet.

Thanks for your reply.
I got stuck because I just don't know how to connect observer with mysql client......
So I try blindly.
By the way, I have tried like this.
At left panel,I start server.
At right, I try to connect.
Connection seems to build ok, but I can't get a prompt shell.

image
My mysql client version is Ver 8.0.34.

@hnwyllmm
Copy link
Collaborator

Sorry for that mysql-client 8.x is not tested.
I created an issue #274

@hnwyllmm hnwyllmm added the bug Something isn't working label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants