Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: optimize task manager #37

Closed
chris-sun-star opened this issue May 25, 2023 · 2 comments
Closed

[Enhancement]: optimize task manager #37

chris-sun-star opened this issue May 25, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@chris-sun-star
Copy link
Member

chris-sun-star commented May 25, 2023

on branch 2.0.x_dev
every time a task is submitted, task manager will create a go routine to execute it, maybe it's a better way to use a coroutine pool, and add timeout for task execution

@chris-sun-star chris-sun-star added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 25, 2023
@powerfooI
Copy link
Collaborator

powerfooI commented Nov 14, 2023

PR #95 fixes the possible concurrent writes to the task and taskResult maps.

@powerfooI
Copy link
Collaborator

If number of wrong tasks bursts the operator manager will panic, because there is no throttling logic in task manager and task goroutines can be created infinitely.

Maybe a throttler should be added into TaskManager struct.

@powerfooI powerfooI self-assigned this Dec 20, 2023
@powerfooI powerfooI changed the title optimize task manager [Enhancement]: optimize task manager Dec 22, 2023
@chris-sun-star chris-sun-star added this to the 2.1.2 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants