Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Replace pngquant with something not requiring Rust #1454

Closed
3 tasks done
barracuda156 opened this issue Jan 8, 2025 · 2 comments
Closed
3 tasks done

[Bug]: Replace pngquant with something not requiring Rust #1454

barracuda156 opened this issue Jan 8, 2025 · 2 comments
Assignees

Comments

@barracuda156
Copy link

What were you trying to do?

The whole project is pure Python, but one dependency, pngquant, pulls in Rust. This is undesirable, since Rust is a huge thing to build and is not supported on a number of platforms. There are alternatives for processing png files, can something else be used instead of pngquant?

Where are you installing/running from?

source build

OCRmyPDF version

No response

What operating system are you working on?

macOS

Operating system details and version

No response

Simple sanity checks

  • Operating system is currently supported by its vendor (not end of life)
  • Python version is compatible with OCRmyPDF
  • This issue is not about a specific input file

Relevant log output

No response

@barracuda156 barracuda156 added the triage Issue needs triage label Jan 8, 2025
@jbarlow83
Copy link
Collaborator

pngquant is optional, not required, so if it poses difficulty it can be omitted.

On macOS, the recommended installation procedure is to use Homebrew, which should give you pre-compiled binaries of pngquant and everything else, on supported releases. (If Apple can't afford to support EOL macOS, I can't either.)

One could also write a plugin to replace pngquant with some other PNG utility if desired.

@github-actions github-actions bot removed the triage Issue needs triage label Jan 8, 2025
@barracuda156
Copy link
Author

@jbarlow83 Thank you for responding. I use MacPorts, but I have opened an issue there, so hopefully pngquant is moved to a variant (in order for it not be a hard dependency).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants