Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that pre-releases have the avoid-version flag #385

Open
kit-ty-kate opened this issue Oct 29, 2024 · 3 comments
Open

Check that pre-releases have the avoid-version flag #385

kit-ty-kate opened this issue Oct 29, 2024 · 3 comments

Comments

@kit-ty-kate
Copy link
Contributor

See ocaml/opam-repository#26799

Most pre-releases should have at least:

flags: avoid-version
available: opam-version >= "2.1.0"

There are of course exceptions (e.g. ocaml-base-compiler which uses the ocaml-beta trick instead) but in general this is true, so it would make sense to have a warning in the linter for this

@shonfeder
Copy link
Contributor

This should be an easy lint to add, but in light of the discussion in ocaml/infrastructure#152 (comment) I'd like to be sure we validate the lint check through whatever explicit process we settle on for these changes.

I'll put this on the queue for the opam maintenance meeting on Thurs.

@punchagan
Copy link
Contributor

I'll put this on the queue for the opam maintenance meeting on Thurs.

@shonfeder curious to know if this did make it to the opam maintenance discussion on Thursday.

@shonfeder
Copy link
Contributor

It did not! We had too many things ahead it in the queue. I'll report back after the meeting tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants