Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL3 - SetRenderClipRect should allow a nil ^Rect #4879

Open
gabstv opened this issue Feb 25, 2025 · 0 comments
Open

SDL3 - SetRenderClipRect should allow a nil ^Rect #4879

gabstv opened this issue Feb 25, 2025 · 0 comments

Comments

@gabstv
Copy link

gabstv commented Feb 25, 2025

Context

In the SDL3 documentation about SetRenderClipRect, by passing a nil pointer, it should reset the clip rect of the referenced renderer, but in Odin, the binding doesn't allow that.

Current implementation:

SetRenderClipRect                :: proc(renderer: ^Renderer, #by_ptr rect: Rect) -> bool

By looking at similar cases (which the binding is correct), it should be:

SetRenderClipRect                :: proc(renderer: ^Renderer, rect: Maybe(^Rect)) -> bool
  • Operating System & Odin Version:
  • Please paste odin report output:
Odin:    dev-2025-02-nightly
OS:      Debian GNU/Linux 12 (bookworm), Linux 6.1.0-29-amd64
CPU:     AMD Ryzen 5 4500 6-Core Processor              
RAM:     15773 MiB
Backend: LLVM 18.1.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant