Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add closed PRs to the branch deleter #1082

Open
xmo-odoo opened this issue Mar 7, 2025 · 0 comments
Open

Add closed PRs to the branch deleter #1082

xmo-odoo opened this issue Mar 7, 2025 · 0 comments
Labels

Comments

@xmo-odoo
Copy link
Collaborator

xmo-odoo commented Mar 7, 2025

Currently the branch deleter is active for merged PRs, but if a PR is closed (because it's been replaced or was found unnecessary or something) then unless the closer remembers to delete the branch it's going to stay there forever clogging the branch list and the info/refs (although sadly it'll clog the info/refs of the base repository forever due to the pr magic ref).

There is no reason for that. Like with merged PRs, we should just assume that unless the branch gets reused it can be deleted.

Also the deletion delay should be reduced to 1 week, probably.

@xmo-odoo xmo-odoo added this to Mergebot Mar 7, 2025
@xmo-odoo xmo-odoo moved this to accepted in Mergebot Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: accepted
Development

No branches or pull requests

1 participant