Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare template documents for furo style docs #1131

Draft
wants to merge 61 commits into
base: dev
Choose a base branch
from

Conversation

fwitte
Copy link
Member

@fwitte fwitte commented Nov 8, 2024

Resolve #1074 (docs with appealing look)
Resolve #1132 (docs story line)
Resolve #1141 (beginner tutorials)

Note: #1142 (advanced tutorials) will be added later.

This PR prepares the change of the docs layout to the furo template. The following things have to considered before merging:

  • Check for compatibility of the old docs pages to the new template
  • Create darkmode replacements for every figure and logo
  • Insert darkmode/lightmode responsive figure inclusion code
  • Check if the docs actually build on readthedocs

On top of that, I updated the .readthedocs.yml configuration file to use the [dev] dependencies and a more up to date python version and delete the extra readthedocs specific requirements.txt file. It also introduces an announcement banner at the top of every page, where the content can be dynamically changed from the announcement.html file in the root of the announcements branch.

The plan is to crowdsource the necessary updates at the upcoming user-meeting.

@pep8speaks
Copy link

pep8speaks commented Nov 8, 2024

Hello @fwitte! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 130:80: E501 line too long (122 > 79 characters)

Comment last updated at 2025-01-16 07:00:41 UTC

@fwitte
Copy link
Member Author

fwitte commented Nov 8, 2024

I added instructions to contribute to this change for the in person meeting in the respective issue #1074

fwitte and others added 24 commits November 21, 2024 15:31
@fwitte fwitte removed the request for review from p-snft November 24, 2024 16:27
docs/requirements.txt Outdated Show resolved Hide resolved
@fwitte
Copy link
Member Author

fwitte commented Dec 9, 2024

For styling please refer to: https://pradyunsg.me/furo/reference/admonitions/

@p-snft p-snft marked this pull request as draft January 15, 2025 10:18
@@ -0,0 +1,7 @@
# %%[sec_1]
import oemof.solph as solph

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'solph' is not used.
import oemof.solph as solph

# %%[sec_2]
import oemof.solph as solph

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'solph' is not used.
@@ -0,0 +1,7 @@
# %%[sec_1]
import oemof.solph as solph

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'solph' is not used.
import oemof.solph as solph

# %%[sec_2]
import oemof.solph as solph

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'solph' is not used.
@@ -0,0 +1,7 @@
# %%[sec_1]
import oemof.solph as solph

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'solph' is not used.
import oemof.solph as solph

# %%[sec_2]
import oemof.solph as solph

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'solph' is not used.
p-snft and others added 3 commits January 15, 2025 11:29
Tox tests did not run without: It tried to run
`python -I -m pip install pytest-cov './{[testenv]deps}'`,
which does not make sense. looks like "deps" needs to be defined.
Copy link
Member

@p-snft p-snft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few thoughts.

docs/support.rst Outdated
Comment on lines 16 to 18
If you have a question and you cannot attend an online meeting you can also
post your question to the `openmod forum <https://forum.openmod.org/>`__. Make
sure to use the :code:`oemof` tag for your submission.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is the solph documentation, we should advice to use oemof-solph for the tag.

docs/support.rst Outdated

User forum
==========

(openmod)
If you have a question and you cannot attend an online meeting you can also
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, the forum is the first resource and if you prefer personal contact, we also have a consultation hour. (Forum posts can be answered asynchronously and answers can also help others.)

CONTRIBUTING.rst Outdated Show resolved Hide resolved

.. code-block:: console

conda install -c conda-forge coincbc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, there cbc is not conda-installable on Windows systems.

@fwitte
Copy link
Member Author

fwitte commented Jan 16, 2025

One bigger task remaining is:

  • We need to discuss how to split up the old usage section on the basic concepts and the advanced concepts sections.

Right now the structure of the old usage.rst is:

  • Quick intro to a first model
    • EnergySystem
    • Bus, Flow, Components
    • Solve the EnergySystem
    • Extract some results
  • Solph components overview (with very detailed information on all components: why would this not be part in the docstrings?!)
  • Investment optimization
  • Multiperiod Investment
  • Mixed Integer Problems
  • Custom constraints
  • Grouping
  • Excel/csv reader
  • Results handling

I would like to restructure that a little bit:

  • Basic concepts
    • EnergySystem
    • Bus, Flow, Component (only a list of components, reference the docstrings for information on components)
    • Model and model debugging/handling errors + warnings
    • Results handling
  • Advanced concepts
    • Investment optimization
    • Mixed integer problems
      • Dispatch
      • Investment
    • Multiperiod modeling
      • Dispatch
      • Investment
    • Custom constraints
    • Grouping

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants