Feat: Display total no. of entities with heading in Organization #10092
Conversation
WalkthroughThis pull request introduces a consistent approach to displaying entity counts across various organization-related tabs. The changes involve modifying localization files and updating multiple components to include a Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
src/pages/Organization/OrganizationView.tsx (2)
54-65: Maintain consistency with heading and translation keys.The heading shows "organizations" while viewing child organizations, which might be confusing. Consider changing it to "child organizations" or similar for clarity.
- <h2 className="text-lg font-semibold">{t("organizations")}</h2> + <h2 className="text-lg font-semibold">{t("child_organizations")}</h2>
57-58: Extract common Badge styling to a shared component.The Badge styling is duplicated across all organization pages. Consider creating a shared component to maintain consistency and reduce duplication.
// src/components/Common/EntityCountBadge.tsx export const EntityCountBadge = ({ count, entity }: { count: number; entity: string }) => ( <Badge className="bg-purple-50 text-purple-700 ml-2 text-sm font-medium rounded-xl px-3 m-3" variant="outline" > {t("entity_count", { count, entity })} </Badge> );Also applies to: 63-63
src/pages/Organization/OrganizationFacilities.tsx (1)
67-69: Standardize translation key usage.Use the common
entity_counttranslation key for consistency with other organization pages.- {t("facility_count", { - count: facilities?.count || 0, - })} + {t("entity_count", { + count: facilities?.count || 0, + entity: "Facility" + })}src/pages/Organization/OrganizationPatients.tsx (1)
102-110: Consider adding ARIA label for screen readers.The Badge component should have an aria-label for better accessibility.
<Badge className="bg-purple-50 text-purple-700 ml-2 text-sm font-medium rounded-xl px-3 m-3" variant="outline" + aria-label={t("entity_count", { + count: patients?.count || 0, + entity: "Patient" + })} >
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
public/locale/en.json(2 hunks)src/components/Facility/FacilityUsers.tsx(1 hunks)src/pages/Organization/OrganizationFacilities.tsx(2 hunks)src/pages/Organization/OrganizationPatients.tsx(2 hunks)src/pages/Organization/OrganizationUsers.tsx(2 hunks)src/pages/Organization/OrganizationView.tsx(1 hunks)
👮 Files not reviewed due to content moderation or server errors (2)
- src/components/Facility/FacilityUsers.tsx
- public/locale/en.json
Proposed Changes
OrganizationTabs #10087@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit
Release Notes
New Features
Improvements
Localization