Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIlter Events In Feed Page #424

Open
dgparmar14 opened this issue Apr 7, 2024 · 6 comments
Open

FIlter Events In Feed Page #424

dgparmar14 opened this issue Apr 7, 2024 · 6 comments
Labels

Comments

@dgparmar14
Copy link
Contributor

dgparmar14 commented Apr 7, 2024

Description:

Integrate filtering options into the feed page for enhanced user experience and content customization. Users can then:

  1. Filter by Repository: Focus on updates from specific repositories.
  2. Event Based Filter: Filter out specific event types for a feed.

Mocukup:

Group 32 (2)

@dgparmar14
Copy link
Contributor Author

@rithviknishad Hey, I'd like to take ownership of implementing the new feature. Please assign it to me.

@sachan13harshit
Copy link
Contributor

@rithviknishad can you please assign this issue , i would like to work on it

@rithviknishad
Copy link
Member

Could you specify how you are planning to achieve this?

@rajku-dev
Copy link
Contributor

rajku-dev commented Dec 31, 2024

@rithviknishad I would like to work on this filtering feature.
Please assign this to me so that i can start working on it.

@rithviknishad
Copy link
Member

How are you planning to solve this though? Does GitHub supports this via their API?

@rajku-dev
Copy link
Contributor

rajku-dev commented Jan 9, 2025

How are you planning to solve this though? Does GitHub supports this via their API?

GitHub's API doesn't directly support filtering events by repository or event type in a single query. However, we can handle this by fetching the events and then apply filtering on it manually.

Here's my approach for implementing this feature

  • Take inspiration from Leaderboard page, but UI of search dropdowns will be similar to the one shown in issue description.
  • Take input through Select and update the search params using updateSearchParams as defined in Leaderboard
  • Fetch all repos of the org(sort by lastUpdatedAt) using GraphQL and set them as options of Select
  • Fetch the events of org using pagination, max we can fetch is 300 from last 90 days - docs
  • Filter the events first by repository(s) and then by Event(s) based on search params

@rithviknishad, if this approach looks good, please assign me this issue, I'll proceed with the implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants