New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible redundant code #363

Closed

Bbulatov opened this issue Nov 25, 2024 · 2 comments

Bbulatov commented Nov 25, 2024

Hello!
During the static analysis was found possible redundant code:

There is redundant checking in the file ext/ox/sax.c:200 in develop:

Please clarify whether this redundant condition can be removed?

Owner

ohler55 commented Nov 25, 2024

It can be removed although please look at the history. Maybe the second was meant to be something else.

Owner

ohler55 commented Dec 25, 2024

Fixed in release v2.14.19.

ohler55 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment