Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setup failed because "curl" wasn't found #31

Open
guilhermelowa opened this issue Sep 15, 2021 · 2 comments
Open

Make setup failed because "curl" wasn't found #31

guilhermelowa opened this issue Sep 15, 2021 · 2 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@guilhermelowa
Copy link

In my first attempt to run make setup after cloning the project, the following command returned an error since I didn't have curl yet (just installed OS)

cd [...]/querido-diario-toolbox/tests/bin && curl -L -O https://github.com/tabulapdf/tabula-java/releases/download/v1.0.4/tabula-1.0.4-jar-with-dependencies.jar /bin/sh: 1: curl: not found make: *** [Makefile:18: download-binaries] Error 127

After I installed curl, make setup finished without errors

@ogecece ogecece added the bug Something isn't working label Oct 1, 2021
@jvanz
Copy link
Member

jvanz commented Oct 6, 2021

I do not consider this is a bug. Actually, it seems more a documentation issue for me. curl is a requirement to running make setup. I think we can work around that adding docs explicitly saying that curl is necessary.

@jvanz jvanz added the documentation Improvements or additions to documentation label Oct 6, 2021
@jvanz
Copy link
Member

jvanz commented Oct 6, 2021

I've added the documentation label to make clear that the bug is a missing docs

@jvanz jvanz added the good first issue Good for newcomers label Oct 6, 2021
@jvanz jvanz moved this to Todo in Querido Diario Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

3 participants