Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Guidelines #5

Open
aassumpcao opened this issue Nov 16, 2020 · 3 comments
Open

Style Guidelines #5

aassumpcao opened this issue Nov 16, 2020 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@aassumpcao
Copy link
Collaborator

Write up style guidelines.

@aassumpcao aassumpcao added the documentation Improvements or additions to documentation label Nov 17, 2020
@jvanz
Copy link
Member

jvanz commented Nov 19, 2020

We definetly shoud write one. My first idea is to follow the standard for the python community. We should also need a tool to do the heavy work for us. I'm happy with black that we already use in the other repositories. I would be great have an easy to use command to format the code for us.

@cuducos
Copy link

cuducos commented Apr 19, 2021

+1 for Black

I'd also suggest isort, flake8 and mypy (as I have seen some type hints around).

I can prepare a PR with some automations on that sense if this helps : )

@ogecece
Copy link
Member

ogecece commented Oct 16, 2021

Trabalhei um pouco nisso :)

Adicionei o isort, flake8 e black no projeto com ab92731 e 40d2c15. E sugeri a adição do check no CI com #40 !

Acho que o mypy seria uma boa também! Pode ficar à vontade @cuducos :)


English

Worked a bit on this :)

Just added isort, flake8 and black in the project with ab92731 and 40d2c15. And suggested the addition of a CI check with #40.

I think mypy would be a good idea too! Make yourself comfortable @cuducos :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

5 participants