Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke-OktaRemoveAccessToken should revoke the access token prior to nulling it out #66

Open
aseigler opened this issue Nov 11, 2024 · 1 comment · May be fixed by #67
Open

Invoke-OktaRemoveAccessToken should revoke the access token prior to nulling it out #66

aseigler opened this issue Nov 11, 2024 · 1 comment · May be fixed by #67

Comments

@aseigler
Copy link

aseigler commented Nov 11, 2024

Invoke-OktaRemoveAccessToken currently sets the script-bound variable containing the cached access token to null. It would be much better from a security perspective if the token were first revoked, then the variables containing them set to null. It is especially important because the process of revoking access tokens requires the access token, and if you've already set it to null, you have effectively lost the handle to the access token and are unable to revoke it directly.

I am more than willing to provide a PR to resolve this properly.

@laura-rodriguez
Copy link
Collaborator

Hi @aseigler,

Thanks for your feedback. We do agree.

This has been part of the team plan, but we haven't had time to implement it due to other priorities.

We're more than happy to accept contributions if you're willing to; please take a look at our contributing guide and CLA.

@aseigler aseigler linked a pull request Nov 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants