Callback downloadReady does not work

[denef]

The callback downloadReady is never called.
It is actually commented and deprecated in code but not in the documentation.

var myTable = new Tabulator(tableFrame, {
    downloadReady:function(fileContents, blob){
          window.alert("File will be downloaded");
                  return true;} 
…

 myTable.download("csv", "file.csv") 

Compare:

https://tabulator.info/docs/6.3/callbacks#download

with:

https://github.com/olifolkerd/tabulator/blob/master/src/js/modules/Download/Download.js
line 18.

constructor(table){
		super(table);

		this.registerTableOption("downloadEncoder", function(data, mimeType){
			return new Blob([data],{type:mimeType});
		}); //function to manipulate download data
		// this.registerTableOption("downloadReady", undefined); //warn of function deprecation
		this.registerTableOption("downloadConfig", {}); //download config
		this.registerTableOption("downloadRowRange", "active"); //restrict download to active rows only

		this.registerColumnOption("download");
		this.registerColumnOption("titleDownload");
	}

	initialize(){
		this.deprecatedOptionsCheck();

		this.registerTableFunction("download", this.download.bind(this));
		this.registerTableFunction("downloadToTab", this.downloadToTab.bind(this));
	}

	deprecatedOptionsCheck(){
		// this.deprecationCheck("downloadReady", "downloadEncoder");
	}	

[olifolkerd]

Hey @denef

Thanks for the headsup, looks like a documentation error there, i will get that fixed in todays patch update.

This functionality was replaced in the 6.0 release with the downloadEncoder:

https://tabulator.info/docs/6.3/download#advanced-intercept

Cheers

Oli :)