Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label markdown formatting does too much #486

Open
will-moore opened this issue Oct 25, 2022 · 3 comments
Open

Label markdown formatting does too much #486

will-moore opened this issue Oct 25, 2022 · 3 comments

Comments

@will-moore
Copy link
Member

See #481 (comment)

The markdown formatter that is used for italics and bold formatting of labels, will also format other markup.
E.g. if the label starts with 4 white-spaces, it will be formatted as code (see comment above) or if starts with a - it will add a bullet point.

Probably makes sense to simply strip all white-space from user-entered text.
We could also strip - and then add it back after formatting with markdown, in case user actually wants " - my label".

@will-moore
Copy link
Member Author

Also, user may actually want text_with_underscores not to be formatted as italics. See https://forum.image.sc/t/bugs-with-labels-in-omero-figures/78829.
We could give user the option to disable/enable markdown formatting for a label, but then useful italics etc wouldn't be possible. Better info on how to \_escape_ markdown might help too.

@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/bugs-with-labels-in-omero-figures/78829/2

@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/bugs-with-labels-in-omero-figures/78829/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants