You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@agrobbin@sferik Could you review this, if you still have an interest in the issue?
#70 was merged without a spec, so I added specs to make my intention clear. If redirect_uri is given in token_params, it should be honored. If not, query parameters added by the OAuth2 provider in a callback should be stripped off from the redirect_uri value to be posted to the token endpoint, to avoid redirect_uri mismatch.
@Noip1 I am not a maintainer of this gem, and contributed #70 more than 7 years ago, so I don't know what my review will add, but I have left a comment on #100 regardless!
@agrobbin @sferik Could you review this, if you still have an interest in the issue?
#70 was merged without a spec, so I added specs to make my intention clear. If
redirect_uri
is given intoken_params
, it should be honored. If not, query parameters added by the OAuth2 provider in a callback should be stripped off from the redirect_uri value to be posted to the token endpoint, to avoid redirect_uri mismatch.Originally posted by @knu in #100 (comment)
The text was updated successfully, but these errors were encountered: