Observation Smoking Status: effectivePeriod profile validation errors (10.27.06)

[jwjahns]

Hello,

While testing the fix to #560 , I am seeing profile validation errors (not Must Support errors) in test 10.27.06 when using effectivePeriod:

The underlying code seems like it intends to filter out these errors:
https://github.com/inferno-framework/us-core-test-kit/blob/767a45aa8ebf4eb3f6825954abb69aeea0eff941/lib/us_core_test_kit/generator/suite_generator.rb#L24-L26

However, the regex strings above do not escape the special regex characters in the URLs (/ and .).
Are these regex strings intended to filter out the errors in my screenshot?
For example, I'd expect
%r{Observation\.effective\.ofType\(Period\):.*http://hl7.org/fhir/us/core/StructureDefinition/us-core-smokingstatus}
to be
%r{Observation\.effective\.ofType\(Period\):.*http:\/\/hl7\.org\/fhir\/us\/core\/StructureDefinition\/us-core-smokingstatus}

---

For convenience, copy of messages in the above screenshot:
Observation/fQvY.HFjvR.SM2FlST0dC6w4: Observation: Slice 'Observation.effective[x]:effectiveDateTime': minimum required = 1, but only found 0 (from http://hl7.org/fhir/us/core/StructureDefinition/us-core-smokingstatus|6.1.0)

Observation/fQvY.HFjvR.SM2FlST0dC6w4: Observation.effective.ofType(Period).end: This element is not allowed by the profile http://hl7.org/fhir/StructureDefinition/dateTime|4.0.1

Observation/fTteYILUg2l4wza155xG2TwK4Qy0a0E8fT2gUZ6Bbz084: Observation.effective.ofType(Period): This element does not match any known slice defined in the profile http://hl7.org/fhir/us/core/StructureDefinition/us-core-smokingstatus|6.1.0 and slicing is CLOSED: Observation.effective.ofType(Period): Does not match slice 'effectiveDateTime' (discriminator: ($this is dateTime))

Observation/f13o6m6OCoYEOlZe-w-sG.w4: Observation.effective.ofType(Period): The Profile 'http://hl7.org/fhir/us/core/StructureDefinition/us-core-smokingstatus|6.1.0' definition allows for the type dateTime but found type Period

[yunwwang]

@jwjahns Thank you for reporting this. Hmm. We forgot to include the regex into error filter. We will add it.
BTW, does the MustSupport choice work as expected?

[jwjahns]

Yes, the MS tests are now passing fine with these resources!

[jwjahns]

Thanks for addressing this! However, in the recent v7.0.0, we're still seeing one last error:

Observation/fTteYILUg2l4wza155xG2TwK4Qy0a0E8fT2gUZ6Bbz084: Observation.effective.ofType(Period).start: This element is not allowed by the profile http://hl7.org/fhir/StructureDefinition/dateTime|4.0.1

This specific variation of error is missing from my initial comment, and it looks like the error filters were updated to only filter errors on Period.end, not Period.start.

(all other errors seem to be filtered correctly from our test runs)

Edit: to clarify, this is test kit version 7.0.0 - this still only applies to US Core version 6.1.0

[yunwwang]

Oh, I see. ;) I will add that also