Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual Light Strengths (feature request) #158

Open
hyakugei opened this issue Feb 12, 2019 · 2 comments
Open

Individual Light Strengths (feature request) #158

hyakugei opened this issue Feb 12, 2019 · 2 comments

Comments

@hyakugei
Copy link
Contributor

Right now all lights "throw" to the range value passed into the ROT.Lighting() object. Is it possible for each individual light have its own range?

@hyakugei
Copy link
Contributor Author

I guess for each set of light strengths i can run/use a new instance of the ROT.Lighting() with that range, and then using the example in the lighting section, combine all those values together... Not sure if the mixing will look as good - going to try it though.

@ondras
Copy link
Owner

ondras commented Feb 14, 2019

Hi @hyakugei ,

your idea makes sense, but only for a 1-pass run of ROT.Lighting. Please note that there is also the possibility to compute the light intensity recursively in multiple passes, where every single cell that was lit in the first pass becomes a (small) light source for the second pass.

So while it is straightforward to make explicit lights have their own range, I have no clue what shall be the range for these secondary (tertiary, ...) light sources.

I am, however, pretty convinced that most people are using ROT.Lighting for a 1-pass only, where the suggested improvement makes complete sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants