Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Package was made ESM-only in a patch release #110

Open
jakebailey opened this issue Sep 24, 2024 · 1 comment
Open

[BUG] Package was made ESM-only in a patch release #110

jakebailey opened this issue Sep 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jakebailey
Copy link

Version 1.3.8 switched the package from CJS to ESM. This is a breaking change, and should have been made in a major release bump.

This was caught on DefinitelyTyped, which contains community-supported types for this package. https://github.com/DefinitelyTyped/DefinitelyTyped/actions/runs/11013392257/job/30581700193#step:12:2874

Would you consider reverting 1.3.8's changes in a v1.3.9, and republishing as a v2 to unbreak this?
@jakebailey jakebailey added the bug Something isn't working label Sep 24, 2024
@jakebailey
Copy link
Author

Additionally, modules were moved around, which is a breaking change too :(

@jakebailey jakebailey mentioned this issue Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jakebailey