Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EFM] Add unit tests for EFM recovery CLI tool #6960

Open
durkmurder opened this issue Jan 30, 2025 · 0 comments
Open

[EFM] Add unit tests for EFM recovery CLI tool #6960

durkmurder opened this issue Jan 30, 2025 · 0 comments
Assignees
@durkmurder
Labels
Preserve Stale Bot repellent Protocol Team: Issues assigned to the Protocol Pillar. S-BFT Tech Debt

Comments

@durkmurder
Copy link
Member

Context

In #6935 we have extended the recovery tool to support extra flags specifically for including & excluding nodes from the participants list. This was needed to support cases where the smart contract is out of sync with the protocol state. Due to urgency of that work unit tests were omitted but they can and should be added.

Definition of done

  • Add unit tests to ensure that include/exclude flags correctly modify the participants list from the protocol state and yield correct results.
@durkmurder durkmurder added Preserve Stale Bot repellent Protocol Team: Issues assigned to the Protocol Pillar. S-BFT Tech Debt labels Jan 30, 2025
@durkmurder durkmurder self-assigned this Feb 3, 2025
@durkmurder durkmurder mentioned this issue Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@durkmurder durkmurder

Labels
Preserve Stale Bot repellent Protocol Team: Issues assigned to the Protocol Pillar. S-BFT Tech Debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@durkmurder