Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste into quick menu works only in insert mode or command mode #2308

Closed
fanantoxa opened this issue Aug 16, 2020 · 1 comment
Closed

Paste into quick menu works only in insert mode or command mode #2308

fanantoxa opened this issue Aug 16, 2020 · 1 comment
Labels
A-input Area: Input management, keyboard layout, IME etc. bug Something isn't working

Comments

@fanantoxa
Copy link
Contributor

Steps to reproduce:

  • Open Oni
  • Ctrl+P
  • Ctrl+v (need to have something in clipboard)
  • Nothing happen < ------
  • Press Esc (close menu)
  • press i (to enter insert mode)
  • Press Ctrl+P
  • Press Ctrl+v
  • Text from clipboard pasted into input

Same for Ctrl+Shift+p, Ctrl+Shift+f

Comment from Ryan C

I expect its this

{
key: "<C-V>",
command: Feature_Clipboard.Commands.paste.id,
condition: "insertMode || commandLineFocus" |> WhenExpr.parse,
},

Since it only runs on insertMode or commandLineFocus (i.e. the vim command line)
Adding textInputFocus should fix that bug, I believe its a mistake its only insertMode and commandLineFocus
It was originally always active, but that obviously clashes with the vim bind so it was changed and must have been missed

I'll fix it after #1716

@bryphe bryphe added bug Something isn't working A-input Area: Input management, keyboard layout, IME etc. labels Aug 17, 2020
@fanantoxa
Copy link
Contributor Author

Fixed by PRs related to #2428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-input Area: Input management, keyboard layout, IME etc. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants