Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-analyser not updating diagnostics #2490

Closed
flukejones opened this issue Sep 21, 2020 · 2 comments
Closed

rust-analyser not updating diagnostics #2490

flukejones opened this issue Sep 21, 2020 · 2 comments
Labels
A-extension Area: Extension/plugin integration, vscode or VimL bug Something isn't working L-rust Language: rust

Comments

@flukejones
Copy link

Per title. Have tried various settings for this including nightly. While it appears that LSP interactions for predictions etc work fine, I never get updates from the "rust-analyzer.checkOnSave.command": "clippy", setting which should run either clippy or check on save.

@bryphe bryphe added A-extension Area: Extension/plugin integration, vscode or VimL bug Something isn't working L-rust Language: rust labels Sep 24, 2020
@flukejones
Copy link
Author

A very quick way to check if this is working is with the following code snippet:

fn main() {
  let x:u8 = 42;
}

change 42 to 'x' and save, you'll get an error highlight if clippy/check runs on save.

@bryphe
Copy link
Member

bryphe commented Jan 20, 2021

Thanks for the helpful repro!

Looks like this was fixed by #2999 as well, which sends the appropriate notification to the extension host on save.

Now, when I save, I get the diagnostics updating:
2021-01-20 14 00 40

@bryphe bryphe closed this as completed Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-extension Area: Extension/plugin integration, vscode or VimL bug Something isn't working L-rust Language: rust
Projects
None yet
Development

No branches or pull requests

2 participants