Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BenchmarkDataset (and Benchmark) for more flexibility #77

Closed
4 tasks done
ben-jy opened this issue Dec 31, 2024 · 0 comments · Fixed by #86
Closed
4 tasks done

Improve BenchmarkDataset (and Benchmark) for more flexibility #77

ben-jy opened this issue Dec 31, 2024 · 0 comments · Fixed by #86
Assignees

Comments

@ben-jy
Copy link
Collaborator

ben-jy commented Dec 31, 2024

The BenchmarkDataset class (and the Benchmark class) should be improved to cover a wider range of use cases. To do :

  • Add parameter to define a batch size, as it depends strongly on the samples dataset dimension
  • Add parameters to choose which components are used as input respectively as target (currently, all components are used as input as well as target), reflecting real-world applications.
  • Make the given time series instantiable dynamically, limiting memory usage typically when a lot of datasets are benchmarked
  • Add parameter to define a pre-processing pipeline. For now, it can be a simple lambda.
@ben-jy ben-jy self-assigned this Dec 31, 2024
@ben-jy ben-jy changed the title Choose input and target time series components for benchmark Improve BenchmarkDataset for more flexibility Jan 8, 2025
@ben-jy ben-jy changed the title Improve BenchmarkDataset for more flexibility Improve BenchmarkDataset (and Benchmark) for more flexibility Jan 8, 2025
@ben-jy ben-jy added this to the v0.8 Benchmarking module improvements milestone Jan 8, 2025
@ben-jy ben-jy linked a pull request Feb 19, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants