Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency with the sample data in the tests #924

Open
hynnot opened this issue Jan 20, 2025 · 0 comments
Open

Remove the dependency with the sample data in the tests #924

hynnot opened this issue Jan 20, 2025 · 0 comments

Comments

@hynnot
Copy link
Contributor

hynnot commented Jan 20, 2025

We depend on the tests with the sample data; if this sample data were to change, the tests would fail. We should try to remove this dependency by providing the data necessary to test the behavior in the tests themselves and, ideally, leaving the database clean again.

To provide this data, we could make a factory with different input parameters to create the data needed. We could start by refactoring these newly created tests: #921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant