Updating ReadMe to support Windows user #747
Conversation
|
@harisankar01 is attempting to deploy a commit to the OONI Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @harisankar01. Thanks for thinking about how to support development on Windows. However, the change you proposed here needs to be discussed further. There might be more scenarios, but consider the situation when we make changes the It might create confusion when these changes are accidentally committed by someone as part of other code changes. As an alternative, can you use separate entries in |
|
Okay. Let me work on it. |
|
Made the changes as per the instructions. Also has issue #746 . Thank you |
| "export": ". ./scripts/populate-git-env.sh && next export", | ||
| "export:win": "./scripts/populate-git-env.sh && next export", |
There was a problem hiding this comment.
These two commands are not really equivalent to each other, since you aren't running the shell script with with . (or source), the exported environment variables aren't actually being included in the context of next *.
I think we either find a way to make the definition of these env vars work on windows, or we just drop the running of those scripts on windows so that we don't mislead a developer into believing they are actually doing something.
pages/search.js
Outdated
| @@ -338,7 +340,7 @@ class Search extends React.Component { | |||
| // When `hideFailure` is true, add `failure=false` in the query | |||
| query[queryParam] = false | |||
| } else { | |||
| delete query[queryParam] | |||
| query[queryParam] = true | |||
There was a problem hiding this comment.
I think this change came from a different branch and should be included a separate PR.
There was a problem hiding this comment.
Okay let me change it.
As per #739, I have added details required for windows developers to run the yarn dev on local environment without errors by changing scripts path in
package.jsonand also added extra documentation to support new users (#745). closes #739 closes #745