Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain field only searches domains but not resolved IP Addresses #775

Open
besendorf opened this issue Aug 2, 2022 · 2 comments
Open

Domain field only searches domains but not resolved IP Addresses #775

besendorf opened this issue Aug 2, 2022 · 2 comments
Assignees
Labels
good first issue Good for newcomers priority/low Nice to have ux This issue is related with UX.

Comments

@besendorf
Copy link

Expected Behavior

I expected the domain field to also search for resolved IP Addresses. As the field says domain or IP address. However it does not. I guess it might find IP Addresses when you enter a IP address as a test target, but I couldn't find an example. I think it would be quite helpful to also search the resolved IP Addresses to better search for IP based blocking and for example to verify that an IP is blocked in a country or AS.

Actual Behavior

Only searches for domains

Steps to Reproduce the Problem

example test: https://explorer.ooni.org/measurement/20220801T235930Z_webconnectivity_US_7018_n1_ZYzC9xGkRrhZZKho?input=https%3A%2F%2Fapps.crowdtangle.com%2Fpublic-hub%2Fcovid19
example search with an IP from that test:
https://explorer.ooni.org/search?test_name=web_connectivity&failure=true&since=2022-08-01&until=2022-08-02&domain=52.42.211.177

@hellais hellais added ux This issue is related with UX. priority/low Nice to have labels Nov 10, 2022
@hellais
Copy link
Member

hellais commented Nov 10, 2022

Currently the domain filter applies to IPs only if the target for testing was specified as a URL containing an IP instead of a domain name (ex. https://8.8.8.8/).

Supporting searching through measurements by filtering on the DNS resolutions is a pretty major backend change.

I think in the interim, we might want to improve the UX of the search filter to clarify what we mean by IP in that context.

@hellais hellais added the good first issue Good for newcomers label Aug 18, 2023
@hellais hellais added this to Roadmap Jan 7, 2025
@hellais hellais assigned majakomel and unassigned easyfriday Jan 7, 2025
@hellais
Copy link
Member

hellais commented Jan 7, 2025

In summary the proposed fix here is the change the suggestion in the search box from "eg. twitter.com or 1.1.1.1" to just "eg. example.com".

@hellais hellais removed this from Roadmap Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers priority/low Nice to have ux This issue is related with UX.
Projects
None yet
Development

No branches or pull requests

4 participants