Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OONI Explorer Domain filter does not ignore Websites Categories filter #845

Open
sloncocs opened this issue Mar 14, 2023 · 3 comments
Open
Assignees
Labels
discuss Needs discussion before proceeding priority/low Nice to have triage Should be triaged through the triage board user feedback requests that have been added to the backlog as a direct result of user feedback or testing

Comments

@sloncocs
Copy link

Expected Behavior

If there is a search by domain, Search should ignore Website Categories filter.

Actual Behavior

If you search by domain and the Website Categories filter doesn't match the category of the domain user is searching for, user gets to the 'No Results Found' page.
Screenshot 2023-03-14 at 19 38 01

Steps to Reproduce the Problem

  1. Set Websites Categories filter to 'Alchohol&Drugs'
  2. Add twitter.com to the Domain field
  3. Press 'Filter Results'

Specifications

NA

@sloncocs sloncocs added bug Something isn't working correctly priority/medium Normal priority issue user feedback requests that have been added to the backlog as a direct result of user feedback or testing triage Should be triaged through the triage board labels Mar 14, 2023
@GermaVinsmoke
Copy link
Collaborator

But it returns results with "Social Networking" category

@sloncocs
Copy link
Author

@GermaVinsmoke, that's right, this happens because twitter.com is categorized as a social network (and is included in this category), thank you for highlighting this!

@hellais
Copy link
Member

hellais commented Apr 3, 2023

I'm not sure we should be adding a special case to bypass the category filter if the domain filter is chosen.

Currently the filters are additive and there are other combinations where you might get empty results if you selected two values that have no common elements. For example if you filter by country and then filter by a ASN that doesn't exist in that country.

Making a special case for domain I fear will make it even more confusing as it would not be clear why one of the filters is being ignored.

Moreover, there are use-case for when you actually might want to have both a domain filter and a category_code filter. In the twitter example, we have several twitter URLs that are categorised under a category other than GRP (because we use the category of the content of the profile). Somebody might want to filter by all measurements related to twitter profiles that are talking about political criticism, in which case applying both domain filter and category_code filter would make sense.

@hellais hellais added priority/low Nice to have and removed priority/medium Normal priority issue bug Something isn't working correctly labels Apr 3, 2023
@jbonisteel jbonisteel added discuss Needs discussion before proceeding and removed funder/otffoss2023-2024 labels Jan 31, 2024
@hellais hellais added this to Roadmap Jan 7, 2025
@hellais hellais removed this from Roadmap Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Needs discussion before proceeding priority/low Nice to have triage Should be triaged through the triage board user feedback requests that have been added to the backlog as a direct result of user feedback or testing
Projects
None yet
Development

No branches or pull requests

5 participants