Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitely capture authentication failures (e.g., expired client certificate) #39

Open
ainghazal opened this issue Mar 29, 2023 · 1 comment
Assignees
Labels
bug Something isn't working prio:high

Comments

@ainghazal
Copy link
Collaborator

Right now, the case for certificate-based authentication for clients does not capture properly an expired certificate. This is specially problematic because it confounds bad credentials with other kind of handshake errors.

@ainghazal ainghazal added the bug Something isn't working label Apr 14, 2023
@ainghazal ainghazal self-assigned this Apr 14, 2023
@ainghazal
Copy link
Collaborator Author

For certificate authentication, we don't need to actually initiate the handshake. We should do a pre-flight check and bail out with an explicit pre-requisite error.

For password-based authentication, we will need to check the server error string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio:high
Projects
None yet
Development

No branches or pull requests

1 participant