Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not fail if we cannot parse raw incoming data #67

Open
ainghazal opened this issue Feb 11, 2024 · 0 comments
Open

do not fail if we cannot parse raw incoming data #67

ainghazal opened this issue Feb 11, 2024 · 0 comments

Comments

@ainghazal
Copy link
Collaborator

right now (under internal/packetmuxer) we will fail if we cannot correctly parse an incoming packet (for instance, if the incoming packet has bogus bytes prepended).

we need to continue receiving, and possibly log & trace this event.
ainghazal added a commit to ainghazal/minivpn that referenced this issue Feb 11, 2024
@ainghazal
bug: continue if received malformed input
5ac4cde 
should not return in the presence of malformed packets.

we still need to properly log & trace these events, but this is a first
defensive reaction to malformed input.

- Related: ooni#67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ainghazal