Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): Invalidate Oracle Cache on Pipeline Reorg #724

Closed
refcell opened this issue Oct 21, 2024 · 1 comment
Closed

fix(client): Invalidate Oracle Cache on Pipeline Reorg #724

refcell opened this issue Oct 21, 2024 · 1 comment

Comments

@refcell
Copy link
Collaborator

refcell commented Oct 21, 2024

Description

Currently, kona-client's caching oracle is not invalidate on reorg. This should be fixed in the kona_client::DerivationDriver when a temporary error is found to match ResetError::ReorgDetected(_, _), the CachingOracle is flushed.
@refcell refcell changed the title fix(bin): Invalidate Oracle Cache on Pipeline Reorg fix(client): Invalidate Oracle Cache on Pipeline Reorg Oct 21, 2024
piotr-roslaniec added a commit to piotr-roslaniec/kona that referenced this issue Oct 30, 2024
@piotr-roslaniec
feat: flush oracle cache on reorg op-rs#724
af13dfd
piotr-roslaniec added a commit to piotr-roslaniec/kona that referenced this issue Oct 30, 2024
@piotr-roslaniec
feat: flush oracle cache on reorg op-rs#724
6c68444
@refcell
Copy link
Collaborator Author

refcell commented Oct 30, 2024

Closed by #756

@refcell refcell closed this as completed Oct 30, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 30, 2024
@piotr-roslaniec
feat: flush oracle cache on reorg #724 (#756)
712fe20 
* feat: flush oracle cache on reorg #724

* fix pr review
refcell pushed a commit that referenced this issue Nov 1, 2024
@piotr-roslaniec @refcell
feat: flush oracle cache on reorg #724 (#756)
1aaf740 
* feat: flush oracle cache on reorg #724

* fix pr review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@refcell