Fix S allocation bug in rsa and outcome_map
#627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My thought is that the labels should be set to the input |
Rosejoycrocker
force-pushed
the
fix-rsa-slices-bug
branch
2 times, most recently
from
2e23d88 to
b20e427
Compare
…ity locations functions `strong_pred` and `zones` must be the same size
Zones criteria was incorrectly indexing using `strong_pred` - should have been using sites in `strong_pred` which contain priority zone sites, not values of `strong_pred` at sites in priority zones
`strong_pred` should be a matrix, with site ids in the first column. Without this, calcs in priority predecessor and zones criteria are incorrect
…g in a zone matters
Simplify and fix how `strong_pred` is used in zoning criteria Add to docs
Remove unnecessary findall Remove unnecessary findall
…additive, not replacement)
…rces and zone members
…nd update references to `Example` to `Test`
… `Example_domain` to `Test_domain`
Implements get_bounds and get_default_bounds to better handle real versus virtual upper bound.
Move `_check_discrete()` and `map_to_discrete()` methods into `sampling.jl` to maintain conceptual consistency.
… storage size, but then S i readjusted according to the factor type
…or factors which are not categorical
Rosejoycrocker
force-pushed
the
fix-rsa-slices-bug
branch
from
b20e427 to
1d6f7af
Compare
Formatting
|
Closing this as has been superceded by #679 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #615
Previously,
S, the number of bins for sensitivity analysis, was set as the max between the inputSand number of bins needed for a categorical variable. These changes set the size of storage as the maximum between the inputSand the size of the categorical variables, and thenSis set as the inputSfor non-categorical variables during analysis.Setting this as a draft for discussion as the labels need to be changed to work with visualisations still.