Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: enable oidc verification #488

Merged
merged 2 commits into from
Feb 5, 2025
Merged

feat!: enable oidc verification #488

merged 2 commits into from
Feb 5, 2025

Conversation

rsdmike
Copy link
Member

@rsdmike rsdmike commented Jan 27, 2025

This PR enables tokens to be verified with an OIDC provider. The console service does NOT provide a token from an OIDC provider, a token must retrieved via other means such as OAuth 2.0 PKCE Flow in our sample-web-ui. Basic JWT token still used for redirection.

BREAKING CHANGE: moves JWT configuration to a new "auth" section in the config.yml along. View config.go for complete example.

@rsdmike rsdmike force-pushed the oauth2 branch 7 times, most recently from 3d6b738 to 70905d6 Compare January 27, 2025 22:00
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 28.00000% with 36 lines in your changes missing coverage. Please review.

Project coverage is 68.35%. Comparing base (d54ab95) to head (3b81ed3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/controller/http/v1/login.go 0.00% 32 Missing ⚠️
internal/controller/ws/v1/redirect.go 0.00% 1 Missing and 1 partial ⚠️
internal/controller/http/router.go 0.00% 0 Missing and 1 partial ⚠️
internal/controller/http/v1/devices.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   68.39%   68.35%   -0.05%     
==========================================
  Files          82       82              
  Lines        9205     9228      +23     
==========================================
+ Hits         6296     6308      +12     
- Misses       2582     2592      +10     
- Partials      327      328       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This PR enables tokens to be verified with an OIDC provider. The console service does NOT provide a token from an OIDC provider,
 a token must retrieved via other means such as OAuth 2.0 PKCE Flow in our sample-web-ui.

BREAKING CHANGE: moves JWT configuration to a new "auth" section in the config.yml along.
View config.go for complete example.
@rsdmike rsdmike marked this pull request as ready for review January 27, 2025 22:52
@rsdmike rsdmike enabled auto-merge (rebase) February 5, 2025 21:32
@rsdmike rsdmike merged commit a60b122 into main Feb 5, 2025
22 of 24 checks passed
@rsdmike rsdmike deleted the oauth2 branch February 5, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants