Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support E-Tag for HTTP sync #1558

Open
condorcet opened this issue Feb 11, 2025 · 2 comments
Open

[FEATURE] Support E-Tag for HTTP sync #1558

condorcet opened this issue Feb 11, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@condorcet
Copy link

Requirements

Problem statement

Currently, "HTTP sync" fetches the body and decides whether to update the flags based on SHA changes.

This process is performed at every polling iteration, which may cause an overhead.

Proposal

HTTP source can support E-Tag.

If E-Tag presented in response headers by server, then HTTP sync can add If-None-Match with the value of E-Tag in headers for further requests.
Server will return response with actual body, only if E-Tag of the content has changed (304 Not Modified otherwise).
This will help to avoid blank requests, when nothing changed in HTTP source.

@condorcet condorcet added enhancement New feature or request Needs Triage This issue needs to be investigated by a maintainer labels Feb 11, 2025
@beeme1mr beeme1mr added good first issue Good for newcomers help wanted Extra attention is needed and removed Needs Triage This issue needs to be investigated by a maintainer labels Feb 11, 2025
@ChihweiLHBird
Copy link

I can try working on this if no one else started the work.

@beeme1mr
Copy link
Member

Sure, that would be great. Thanks @ChihweiLHBird

@beeme1mr beeme1mr removed the help wanted Extra attention is needed label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants